Use values from settings.yaml #8

New issue

Closed

opened 2026-04-18 16:04:27 +00:00 by SaschaFuksa · 0 comments

SaschaFuksa commented 2026-04-18 16:04:27 +00:00

Owner

Copy link

There are some places in code where information are hardcoded. The same information are in the settings.yaml.
Example: model_path: models/ggml-model.bin
src/transcription/whisper_service.py: model_path: str = "/app/models/ggml-model.bin",

This should be: model_path: str = "/app/" + config.model_path
Check the whole repo for similar cases and fix them

There are some places in code where information are hardcoded. The same information are in the settings.yaml. Example: model_path: models/ggml-model.bin src/transcription/whisper_service.py: model_path: str = "/app/models/ggml-model.bin", This should be: model_path: str = "/app/" + config.model_path Check the whole repo for similar cases and fix them

Tasch referenced this issue from a commit 2026-04-18 19:06:01 +00:00

Fix #8: Use values from settings.yaml instead of hardcoded paths

Tasch referenced this issue from a pull request that will close it, 2026-04-18 19:06:06 +00:00

Batch: Fixes #8 #10

SaschaFuksa closed this issue 2026-04-18 19:08:40 +00:00

SaschaFuksa referenced this issue from a commit 2026-04-18 19:08:40 +00:00

Merge pull request 'Batch: Fixes #8' (#10) from batch/8 into master

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

No results found.

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Tasch/whisper-transcribe#8

No description provided.