Fix #63: Save of settings failed #66

Merged

SaschaFuksa merged 1 commit from batch/63 into master

2026-04-22 15:43:07 +00:00

Tasch commented

2026-04-22 15:12:34 +00:00

Owner

No description provided.

Tasch added 2 commits

2026-04-22 15:12:34 +00:00

Fix #64 : Record Button still not working

CI / lint (pull_request) Has been cancelled

Details

CI / test (pull_request) Has been cancelled

Details

daad4eaf06

Root cause: startRecording() silently caught exceptions without
surfacing errors to the user, making the button appear broken
when the backend call failed or threw. Since the #error element
was removed in the UI redesign, the error was completely invisible.

Changes:
- Add explicit error message to status element ('❌ ' + err.message)
  so the user can see why recording didn't start
- Add HTTP status to the generic 'Failed to start session' message
- Show error in debugInfoEl (visible in current-session-panel) when available
- Clean up UI state (remove 'recording' class) on error
- Add recordBtnClick() wrapper for onclick attribute as belt-and-suspenders
  in addition to the addEventListener
- Extract onclick to HTML for maximum compatibility

Fix #63 : Save settings to writable /app/settings dir instead of read-only mount

CI / lint (pull_request) Has been cancelled

Details

CI / test (pull_request) Has been cancelled

Details

08c4aa7007

The settings.yaml is mounted read-only (:ro) in Docker. Writing to it causes
OSError: [Errno 30] Read-only file system. Instead, write to
/app/settings/settings.yaml (a Docker volume mount) and read the read-only
mount as the source of truth for existing values.

Changes:
- update_settings() now reads from /app/settings.yaml (read-only mount) and writes
  to /app/settings/settings.yaml (writable volume)
- docker-compose.yml mounts ./settings as /app/settings for persistence
- No changes to get_settings() - still reads from in-memory app_config